Project panel bug fixes #845
Conversation
…z-index of toolbar.
…for jstree expand/collapse and all content changes.
Add option to suppress revealing of jstree selection.
ghost
assigned 
|
Reviewing |
| @@ -66,7 +66,7 @@ define(function (require, exports, module) { | |||
| // Navigate | |||
| exports.NAVIGATE_QUICK_OPEN = "navigate.quickOpen"; | |||
| exports.NAVIGATE_GOTO_DEFINITION = "navigate.gotoDefinition"; | |||
| exports.NAVIGATE_GOTO_LINE = "navigate.gotoLine"; | |||
| exports.NAVIGATE_GOTO_LINE = "navigate.gotoLine"; | |||
There was a problem hiding this comment.
Since you're fixing one, you might as well fix them all :-)
|
I found a bug in the new implementation:
Results: |
| @@ -0,0 +1,167 @@ | |||
| /* | |||
There was a problem hiding this comment.
Thanks for factoring this into a new file! :-)
There was a problem hiding this comment.
Woohoo. And someday a refactored ProjectManager will fit in here too.
|
Done with initial review. Looks like you need to do another merge with master. |
Conflicts: src/brackets.js src/utils/ViewUtils.js src/view/ViewCommandHandlers.js
|
Fixed the bug Glenn found. Merged with master. |
|
Sweet, thanks for cleaning all this up @jason-sanjose. Looking forward to seeing it land. |
|
Found another bug:
|
|
I just noticed another issue too: the editor shadow is not adjusted when the window is resized. Open a file, scroll a bit so you get the shadow and make the window wider. The shadow doesn't get wider. |
|
Fixed the Glenn's latest issues. |
|
Thanks, Jason. Everything is looking great, but there is one last minor issue: when the sidebar is collapsed, if you drag it slowly to open it, it always snaps shut. If you drag it really fast you can get it to open. It looks like this is due to the mousemove logic that snaps the sidebar closed when e.clientX < 10. |
|
Looks great! Merging. |
FYI @ryanstewart - Opportunistic refactor of sidebar resize handling to clean up dependencies in ProjectManager.js and brackers.js. Sets the stage for a future ProjectManager UI separation.